Skip to content

Fix issue with Algolia's docsearch object being missing in pages with tabs #7470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix issue with Algolia's docsearch object being missing in pages with tabs #7470

merged 1 commit into from
Oct 6, 2023

Conversation

@panreyes
Copy link
Contributor

@panreyes panreyes commented Jun 5, 2023 •
edited by YuriSizov
Loading

Fixes #7469

@Piralein Piralein added bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end labels Jun 5, 2023
@coppolaemilio coppolaemilio requested review from YuriSizov and mhilbrunner and removed request for YuriSizov June 6, 2023 09:17
@mhilbrunner mhilbrunner added this to the 4.1 milestone Jun 7, 2023
@mhilbrunner
Copy link
Member

mhilbrunner commented Jun 7, 2023

Hey and thanks for contributing! This looks like a good potential fix for the issue, I'll build and test it locally to make sure and will review those scripts a bit. :)

@mhilbrunner mhilbrunner merged commit 7a46f23 into godotengine:master Oct 6, 2023
@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 6, 2023

Merged in master. Will be cherry-picked to other branches soon if nothing comes up. Thanks for the fix! And sorry this has been sitting for a while :)

@panreyes panreyes deleted the docsearch_not_available_fix branch October 6, 2023 11:42
@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 8, 2023

Cherry-picked to 4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@Piralein Piralein Piralein approved these changes

Assignees

No one assigned

Labels

bug cherrypick:4.0 content:website Issues related to adding website features and fixing bugs, whether on the front or back-end

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

Algolia's docsearch object is not available in some pages

3 participants

@panreyes @mhilbrunner @Piralein