Update threading code examples to use new syntax #7483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piralein
added
bug
area:manual
akien-mga
approved these changes
Jun 8, 2023
Member
akien-mga
left a comment
akien-mga
left a comment
There was a problem hiding this comment.
LGTM. I don't remember what's the consensus regarding the use of type hints in examples but assuming it's recommended / allowed, this should be good to go.
mhilbrunner
approved these changes
Jun 9, 2023
Member
|
re: type hints, see GDScript style guide. I think in this case it's okay to have them :)
Yes exactly. Thanks for overhauling this page! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some threading code examples still use old Godot 3.x syntax which doesn't work in 4.x anymore. Updated a few code sample so that they compile and run correctly.
Also removed the
article_outdatedtag, seems like the article is now pretty well up-to-date. I assume that tag is manually handled like this and not done by some automatic process?