Added note near top of license compliance section regarding contribution. #7484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the "Best Practices for Engine Contributors" page.
…contributors" section
…t Practices for Engine Contributors" to help redirect people interested in license contribution from a contributor perspective.
Piralein
added
enhancement
area:about
YuriSizov
reviewed
Jun 8, 2023
…practices section. Reworded Note in complying with licenses section.
YuriSizov
approved these changes
Jun 9, 2023
Contributor
YuriSizov
left a comment
YuriSizov
left a comment
There was a problem hiding this comment.
The period should probably not be included in the link. But otherwise looks good!
Co-authored-by: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
Member
|
Thanks and congrats on your first merged contribution to Godot's documentation! |
mhilbrunner
added a commit
to mhilbrunner/godot-docs
that referenced
this pull request
Aug 1, 2023
…ion. (godotengine#7484) Co-authored-by: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com> Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a difficult time searching the docs for license compliance from an Engine contribution perspective. Initially, I didn't realize that the About section Complying with Licenses tab only covers license compliance from a user perspective. It took some time and digging to locate the information on license compliance as an Engine contributor. I added a note at the top of the Complying with Licenses section specifying that the page is strictly in regards to user-side compliance and offers a link to the page with the info on license compliance as a contributor.
I also made some grammatical adjustments to the last two paragraphs in the "Best Practices for Engine Contributors" page.