Skip to content

Conversation

@raulsntos
Copy link
Member

@raulsntos raulsntos added bug topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.0 labels Jun 13, 2023
@paulloz
Copy link
Member

paulloz commented Jun 14, 2023

LGTM.
Note: it might be better to use ChildType.PropertyNames.FuncProperty instead of "FuncProperty", but it's probably not that big of a deal.

@raulsntos
Copy link
Member Author

Note: it might be better to use ChildType.PropertyNames.FuncProperty instead of "FuncProperty", but it's probably not that big of a deal.

Agreed, but this whole page uses strings everywhere already. To be honest, I think the C# examples in this page should be rewritten to avoid strings and using Get/Set/Call/Connect when possible. But I will leave that for a future PR.

@mhilbrunner mhilbrunner merged commit c924ee8 into godotengine:master Jul 22, 2023
@mhilbrunner
Copy link
Member

Thanks! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants