tell codespell to ignore the locale code page #7519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
bug
content:website
Piralein
reviewed
Jun 15, 2023
Contributor
Author
|
Fixed. |
skyace65
force-pushed
the
BuildFix
branch
2 times, most recently
from
ad2e81f to
59517d3
Compare
skyace65
changed the title
Contributor
Author
|
I Changed this PR to ignore the entire locale codes file. Updated the original description. |
akien-mga
approved these changes
Jun 16, 2023
akien-mga
reviewed
Jun 16, 2023
| | MM, BU | Myanmar | | ||
| | RO | Romania | | ||
| | VN | Viet Nam | | ||
| .. image:: img/expres.png |
Member
There was a problem hiding this comment.
We could probably rename that file to something not truncated and get rid of the ignore lines file altogether, but maybe we'll need it in the future for some other false positives.
Member
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Originally this was just going to add the latest things to break CI, but Akien suggested it would just be simpler to ignore the page in the contributors chat. And given that almost the entire ignore lines file was from that page I'm inclined to agree, so this PR makes codespell ignore that entire page now.