GDScript: Document static variables #7524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piralein
added
enhancement
area:manual
dalexeev
force-pushed
the
gds-static-vars
branch
from
38f23de to
86d74d2
Compare
dalexeev
commented
Jun 25, 2023
| func _init(): | ||
| super(5) | ||
|
|
||
| Static constructor |
Member
Author
There was a problem hiding this comment.
Suggested change
| Static constructor | |
| Static initializer |
?
Contributor
NathanLovato
left a comment
NathanLovato
left a comment
There was a problem hiding this comment.
Great contribution overall, I left some suggestions that I think would help make this more accessible.
| B.x = 3 | ||
| prints(A.x, B.x) # 3 3 | ||
|
|
||
| Static functions can use static member variables. A static variable initializer can call a static function. |
Contributor
There was a problem hiding this comment.
The first sentence is mentioned before. The second sentence means that you can write something like this, right?
static var a = some_static_function(value)
If so, it'd be good to have a snippet here.
Member
Author
There was a problem hiding this comment.
I've removed this as it's more related to #7507.
dalexeev
force-pushed
the
gds-static-vars
branch
from
86d74d2 to
e297003
Compare
Contributor
|
This change also fixes #7487. |
MisoMosiSpy
reviewed
Jun 30, 2023
MisoMosiSpy
reviewed
Jun 30, 2023
dalexeev
force-pushed
the
gds-static-vars
branch
from
e297003 to
8488729
Compare
MisoMosiSpy
reviewed
Jul 3, 2023
Contributor
MisoMosiSpy
left a comment
MisoMosiSpy
left a comment
There was a problem hiding this comment.
Look good to me now, thanks!
skyace65
approved these changes
Jul 4, 2023
Contributor
|
@NathanLovato any other changes you think need to be made? |
NathanLovato
approved these changes
Jul 5, 2023
Contributor
|
@skyace65 all good! |
Contributor
|
Thanks! |
This was referenced Jul 22, 2023
mhilbrunner
pushed a commit
that referenced
this pull request
Aug 1, 2023
GDScript: Document static variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because godotengine/godot#77129 hasn't been merged yet.Comments are very welcome.