Skip to content

Conversation

@rametta
Copy link
Contributor

@rametta rametta commented Jun 18, 2023

The explanation for creating visual shaders seems to be outdated. There is no more option for creating a visual shader right below a normal shader, now you must pick visual shader by picking the correct "type" from the create shader dialog. This PR updates the docs and images to reflect this new workflow

@skyace65
Copy link
Contributor

Two issues with those images. One they're way too big, I'm assuming you took screenshots on a 4K screen, those need to be scaled down. Additionally, we're changing over from png to webp. You can find information on doing both of those here.

@skyace65 skyace65 added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation needs work Needs additional work by the original author, someone else or in another repo labels Jun 19, 2023
@rametta
Copy link
Contributor Author

rametta commented Jun 19, 2023

@skyace65 I've downsized the images and converted to webp. Cheers!

@skyace65
Copy link
Contributor

What did you use when scaling the images down and converting to webp? There's a noticeable amount of compression artifacts in those images.

@rametta
Copy link
Contributor Author

rametta commented Jun 20, 2023

I used Squoosh. I think I downsized too far before. I've redid it, and re-pushed. Should be good now.

@skyace65
Copy link
Contributor

Sorry to ask for another change but could you do the images again and use the lossless compression for Squoosh. There's still very slight artifacts in the images. I talked with another maintainer and going forward we'll probably ask for lossless compression unless it's a over 300KB file. I'm making a PR for the image guide now so that's clearer in the future.

@rametta
Copy link
Contributor Author

rametta commented Jun 23, 2023

@skyace65 No worries. Re-pushed with lossless 🙂

@skyace65 skyace65 merged commit 8d5eeed into godotengine:master Jun 23, 2023
@skyace65
Copy link
Contributor

Thanks for the fixes! And congrats on your first merged PR!

@rametta rametta deleted the patch-1 branch June 23, 2023 23:51
@Piralein Piralein removed the needs work Needs additional work by the original author, someone else or in another repo label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants