Changed a code example that didn't follow the style guide #7564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piralein
added
enhancement
area:manual
Piralein
approved these changes
Jun 27, 2023
skyace65
approved these changes
Jun 29, 2023
Contributor
|
Thanks! Congrats on your first merged PR! And for future reference, when you make a PR you want to create a new branch on your fork of the repository for it, using master can make things weird. If you need any help we have a guide on using git here. |
mhilbrunner
pushed a commit
that referenced
this pull request
Aug 1, 2023
Changed a code example that didn't follow the style guide
mhilbrunner
pushed a commit
that referenced
this pull request
Aug 1, 2023
Changed a code example that didn't follow the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The style guide says to name signals in past tense. The style guide also contains a code example with "signal spawn_player". I don't see any reason to break naming conventions here.