-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update gdextension_cpp_example.rst to avoid unquoted compatibility_minimum trap #7865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… errors if extended to unquoted x.y.z format. Fixes #7864
AThousandShips
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that with quotes the underlying parsing in ConfigFile does give the correct results
dsnopek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
While you're at it, you could here also fix the wrong ... |
|
Edit: My bad, got it backward This is already handled in, so shouldn't be done here: |
|
Good call. Thanks and congrats on your first merged contribution to Godot's docs! |
|
Cherry-picked to 4.1 |
Fixes #7864 - demonstrates to reader that
compatibility_minimumis better enclosed in quotes (to avoid a misleading error from parsing unquoted three-element version numbers e.g.4.1.1).