Skip to content

Conversation

@dashdotdashdot
Copy link
Contributor

@dashdotdashdot dashdotdashdot commented Aug 31, 2023

Fixes #7864 - demonstrates to reader that compatibility_minimum is better enclosed in quotes (to avoid a misleading error from parsing unquoted three-element version numbers e.g. 4.1.1).

… errors if extended to unquoted x.y.z format.

Fixes #7864
@AThousandShips AThousandShips added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 labels Aug 31, 2023
@AThousandShips AThousandShips requested a review from a team August 31, 2023 10:21
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that with quotes the underlying parsing in ConfigFile does give the correct results

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@capnm
Copy link
Contributor

capnm commented Sep 1, 2023

While you're at it, you could here also fix the wrong [Icon] comments...
See godotengine/godot#75472 :

...

[icons]
GDExample = "res://icons/icon_gdexample.svg"

@AThousandShips
Copy link
Member

AThousandShips commented Sep 1, 2023

It is fixed, you're out of date

Edit: My bad, got it backward

This is already handled in, so shouldn't be done here:

@mhilbrunner mhilbrunner merged commit 8f4347e into godotengine:master Sep 13, 2023
@mhilbrunner
Copy link
Member

Good call. Thanks and congrats on your first merged contribution to Godot's docs!

@mhilbrunner
Copy link
Member

Cherry-picked to 4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug

Projects

None yet

7 participants