Add missing C# code in making plugins tutorial #7867
Merged
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
added
enhancement
topic:dotnet
area:manual
raulsntos
requested changes
Sep 1, 2023
Member
raulsntos
left a comment
raulsntos
left a comment
There was a problem hiding this comment.
Thanks for contributing to the .NET documentation! Looks great, just a few comments about naming convention.
mateuseap
force-pushed
the
feat/making_plugins
branch
from
521b40f to
2d12854
Compare
raulsntos
reviewed
Sep 1, 2023
Co-authored-by: Raul Santos <raulsntos@gmail.com>
mateuseap
force-pushed
the
feat/making_plugins
branch
from
2d12854 to
7648846
Compare
raulsntos
approved these changes
Sep 2, 2023
Member
There was a problem hiding this comment.
LGTM.
The GDScript example was added in #6103 to the 4.0 documentation so I added the cherry pick labels accordingly. That PR was also cherry-picked to the 3.5 and 3.6 documentation, not sure if we want to cherry-pick that far, if so the C# example is still valid but we'd want to remove the partial modifier for 3.x.
mhilbrunner
approved these changes
Sep 2, 2023
Member
|
Thank you! Merged. |
Member
|
Cherry-picked to 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Closes: #7859