Fix SIZE built-in in fog shader reference #7897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been renamed from EXTENTS; while its description was completely unrelated (copied from the sky shader reference)
mhilbrunner
approved these changes
Sep 13, 2023
mhilbrunner
added
bug
area:manual
Member
|
Merged. Thanks and congrats on your first merged contribution! |
Member
|
Cherry-picked to 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been renamed from EXTENTS in godotengine/godot@a598196; while its description was completely unrelated (copied from the sky shader reference)
The phrasing isn't the most elegant, but I felt that listing the
FogVolumeShapeenum values like it's done in theFogVolumereference would've been too repetitive and unelegant to write in the table.