Skip to content

Fixed URL underscore in general_optimization.rst #7939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed URL underscore in general_optimization.rst #7939

wants to merge 1 commit into from

Conversation

@imnachos
Copy link
Contributor

@imnachos imnachos commented Sep 17, 2023

Added double underscore to fix

@AThousandShips
Copy link
Member

AThousandShips commented Sep 17, 2023

You should target master not 4.1, changes can then be cherry picked, see here.

If you need more information about the update process please see: PR Workflow - Updating your branch.

@AThousandShips AThousandShips added needs work Needs additional work by the original author, someone else or in another repo content:proofreading Issues and PRs related to proofreading the documentation area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Sep 17, 2023
@imnachos imnachos changed the base branch from 4.1 to master September 17, 2023 11:20
@imnachos imnachos changed the base branch from master to 4.1 September 17, 2023 11:20
@imnachos
Copy link
Contributor Author

imnachos commented Sep 17, 2023

Declining and re-raising to master.

@imnachos imnachos closed this Sep 17, 2023
@AThousandShips AThousandShips added archived and removed needs work Needs additional work by the original author, someone else or in another repo labels Sep 17, 2023
@AThousandShips
Copy link
Member

AThousandShips commented Sep 17, 2023

Superseded by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

archived area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:proofreading Issues and PRs related to proofreading the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imnachos @AThousandShips