Changed Input. to event. in the event_is_action_pressed() example function #7944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us section since it was not using the event parameter.
AThousandShips
added
bug
area:manual
AThousandShips
approved these changes
Sep 18, 2023
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
Correct both functionally and in line with the description
Sauermann
approved these changes
Sep 18, 2023
Contributor
Sauermann
left a comment
Sauermann
left a comment
There was a problem hiding this comment.
Using event is more appropriate here.
mhilbrunner
approved these changes
Sep 18, 2023
Member
|
Merged, thanks and congrats on your first merged contribution to Godot's docs! 🎉 |
Member
|
Cherry-picked to 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function event_is_action_pressed() within the Windows focus handling section was using the same code from the above function input_is_action_pressed and was not using the event parameter which is was made for.
The function is designed to replace event.is_action_pressed() to handle a defocused window and controller inputs.
I believe this is a simple typo.