Update spatial_shader.rst #8015
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference page suggests a very unfortunate lighting function that modulades the color values in ALBEDO again. This does not seem representative of the shading model. Also, it omitted LIGHT_COLOR; repalcing the ALBEDO term with LIGHT_COLOR gives a much more expected diffuse lighting example.
mhilbrunner
approved these changes
Sep 27, 2023
mhilbrunner
added
bug
topic:rendering
area:manual
Member
|
Merged. Thanks and congrats on your first merged contribution to Godot's docs! For future PRs, Pull Request titles and commit messages are best when they not only contain where something was changed, but also a roughly what/why :) |
Member
|
Cherry-picked to 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference page suggests a very unfortunate lighting function that modulades the color values in ALBEDO with ALBEDO. This does not seem representative of the 4.x shading model. Additionally, it omitted LIGHT_COLOR.
Fix: Replacing the ALBEDO term with LIGHT_COLOR yields a much more predictable diffuse lighting example.