Remove the documentation of an unimplemented feature of the tilemap selection tool #8046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
@AThousandShips there is no need for implementation, the documentation is just outdaded technically. @ershn shouldn't it be documented that |
Member
|
Got it backwards indeed |
Piralein
added
enhancement
area:manual
Right clicking with the tilemap select tool doesn't remove the selection so remove the documentation about it. Document the behavior of the Delete key.
ershn
force-pushed
the
remove_doc_of_unimplemented_feature_of_tilemap_select_tool
branch
from
92442e5 to
7cc59d3
Compare
Contributor
Author
|
@Minoxs Yes, that seems reasonable. I added that to the PR. |
Member
|
Thanks! Merged. |
Member
|
Cherry-picked to 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that right clicking with the tilemap selection tool removes the selection.
However, when you do so in Godot 4.1.1 nothing happens. A right click behaves exactly the same as a left click.
I initially opened an issue on the engine repository thinking it was a bug, but after talking with contributors it seems more likely that the documentation is wrong.
Removing tiles with the selection tool is not very intuitive and does indeed seem a bit weird.
godotengine/godot#81933