Update gdextension_cpp_example.rst (Clarification rwt dump extension API) #8084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused filename parameter from --dump-extension-api command in GDExtension tutorial and clarified language after.
mhilbrunner
added
enhancement
area:manual
Contributor
|
I am a bit confused why you want to remove the optional file name option. Can you clarify why? |
Contributor
Author
|
Because there is no filename option. This is not a request to remove it, it
is updating the docs to be correct.
…On Mon, Oct 9, 2023, 4:52 AM Patrick Exner (FlameLizard) < ***@***.***> wrote:
I am a bit confused why you want to remove the optional file name option.
Can you clarify why?
—
Reply to this email directly, view it on GitHub
<#8084 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH3QAM6HLWYTJMT2WRVIUM3X6O3LVAVCNFSM6AAAAAA5LI2ZYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGU4DKOJXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
paddy-exe
approved these changes
Oct 9, 2023
Contributor
paddy-exe
left a comment
paddy-exe
left a comment
There was a problem hiding this comment.
Just tested this with 4.1. You were right. The option for a custom name of the json file doesn't exist. Thanks for the correction and clarification!
mhilbrunner
approved these changes
Oct 21, 2023
Member
|
Thanks, and congrats on your first merged PR for Godot's docs! And thanks paddy-exe for the review :) |
Contributor
Author
|
Thanks all! |
mhilbrunner
added a commit
that referenced
this pull request
Nov 11, 2023
Update gdextension_cpp_example.rst (Clarification rwt dump extension API)
Member
|
Cherry-picked to 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused filename parameter from --dump-extension-api command in GDExtension tutorial and clarified language after.