📄Fix internationalizing games outdated setting path #8091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good! The image right below that part of text needs to be updated as well. Here's an image to replace it with. |
skyace65
added
enhancement
area:manual
Contributor
Author
|
Image updated @skyace65 |
Contributor
|
The image needs to be in webp format. We've slowly been converting everything from pngs. Also please try and keep everything in 1 commit, if you don't know how to do that we have a guide here. |
Leggy7
force-pushed
the
master
branch
2 times, most recently
from
bd03ed0 to
455fcf7
Compare
fixed locale path on project settings Delete tutorials/i18n/img/locale_test.png Add files via upload updated image in webp format
Contributor
Author
|
Uh sorry, wasn't aware of the workflow. Set up the correct image format. |
Contributor
|
Thanks! And congrats on your first merged PR! |
Member
|
Cherry-picked to 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated path to Locale setting to match the doc version 4.1