Skip to content

Conversation

@tobloef
Copy link
Contributor

@tobloef tobloef commented Sep 29, 2023

This PR fixes some outdated information in the CLion setup guide. It appears that the changes from godotengine/godot@39facb3 were never propagated to this document.

I have updated one of the screenshots while doing this, but JetBrains has changed their IDE themes a bit since the original ones were taken. If this is too noticeable, let me know and I will redo the other screenshots in the document as well (or do a sneaky Photoshop on the original screenshot instead of retaking it 👀).

@tobloef tobloef changed the title Fix CLion build/debugging steps Fix CLion debugging steps Sep 29, 2023
@paddy-exe paddy-exe added the area:engine details Issues and PRs related to the Engine Details section of the documentation label Sep 29, 2023
@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 5, 2023

Thanks for contributing!

Would be great if you could go ahead and convert it to WebP while you're at it. We changed from PNG to WebP in the mean time, so newly added/edited pictures should be in WebP by default. :) (See Image Contribution Guidelines for reference if needed.)

If you want to bother with the other screenshots feel free, but it's IMO not that necessary.

@tobloef
Copy link
Contributor Author

tobloef commented Oct 11, 2023

@mhilbrunner I have converted the image to WebP 👍🏻

@skyace65 skyace65 merged commit a84cd8e into godotengine:master Nov 28, 2023
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:engine details Issues and PRs related to the Engine Details section of the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants