Skip to content

Conversation

@rtflynn
Copy link
Contributor

@rtflynn rtflynn commented Sep 29, 2023

For windows laptops with a 'function' key, F1 actually opens a microsoft edge browser and makes a useless bing query. We can still open the integrated class reference by using 'fn + F1'. Reflect this in the documentation.

For windows laptops with a 'function' key, F1 actually opens a microsoft edge browser and makes a useless bing query. We can still open the integrated class reference by using 'fn + F1'. Reflect this in the documentation.
@skyace65 skyace65 added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation cherrypick:4.0 cherrypick:4.1 labels Sep 30, 2023
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this applies to Linux laptops as well, and any windows laptops loaded with Linux. I'll check on mine with a USB tomorrow.

Co-authored-by: Matthew <matthewehr@hotmail.com>
@rtflynn
Copy link
Contributor Author

rtflynn commented Oct 2, 2023

I'm new to git and not sure I'm holding it right. I think I added the requested change but not sure if I have to do something more for it to become visible on your end.

@skyace65 skyace65 merged commit 228c10e into godotengine:master Oct 3, 2023
@skyace65
Copy link
Contributor

skyace65 commented Oct 3, 2023

You did it mostly correctly, the change that was needed was applied. For future reference please keep PR's to 1 commit. I can do a squash and merge since this is your first one but please keep it to 1 commit going forward. If you don't know how to do that we have a guide here. That page also goes over using Git in general so it might be helpful to you for other stuff since you're new to Git.

This PR is failing CI but I'm merging it anyway since you didn't cause that issue, it's from spelling errors on other pages I just fixed in a different PR.

Congrats on your first merged PR!

mhilbrunner pushed a commit that referenced this pull request Oct 8, 2023
Add note regarding the fn key when trying to open the class reference in editor
@mhilbrunner
Copy link
Member

Cherry-picked to 4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:getting started Issues and PRs related to the Getting Started section of the documentation cherrypick:4.0 enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants