Skip to content

Add C# Tips to 3d tutorial game step 6 #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2023
Merged

Add C# Tips to 3d tutorial game step 6 #8109

merged 1 commit into from
Oct 21, 2023

Conversation

@strobelt
Copy link
Contributor

@strobelt strobelt commented Sep 30, 2023

Context

On the page about jumping and squashing there are some not obvious behaviors when using C#. This PR adds some info about them and a link to more docs.

@strobelt strobelt changed the title Add C# Tips to 3d tutorial game Add C# Tips to 3d tutorial game step 6 Sep 30, 2023
@Piralein Piralein added enhancement topic:dotnet area:getting started Issues and PRs related to the Getting Started section of the documentation labels Oct 2, 2023
@mhilbrunner mhilbrunner requested a review from raulsntos October 6, 2023 11:21
raulsntos
raulsntos reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the .NET documentation!

@AThousandShips
Copy link
Member

AThousandShips commented Oct 14, 2023 •
edited
Loading

I don't think you need to do these spelling fixes, they don't fire CI currently, I think your error happened before it was fixed, please restore and test as it is outside of the scope of this PR

Other PRs are passing fine so this is fixed already and shouldn't be fixed like this

@strobelt strobelt force-pushed the add-csharp-tips-to-jump-and-squash-3d-tutorial branch from 254c3ab to 7cd2a2d Compare October 14, 2023 15:59
@AThousandShips
Copy link
Member

AThousandShips commented Oct 14, 2023

You actually need to rebase your branch, this has already been fixed

@strobelt
Copy link
Contributor Author

strobelt commented Oct 14, 2023

You actually need to rebase your branch, this has already been fixed

Yes! I just did this :)

I am still learning how to deal with this CI. Thanks for the help

@AThousandShips
Copy link
Member

AThousandShips commented Oct 14, 2023

Please squash your commits into one, see here

@strobelt strobelt force-pushed the add-csharp-tips-to-jump-and-squash-3d-tutorial branch from f59a42c to 16a9377 Compare October 14, 2023 17:30
@strobelt
Copy link
Contributor Author

strobelt commented Oct 14, 2023

Please squash your commits into one, see here

Done!

mhilbrunner
mhilbrunner reviewed Oct 15, 2023
View reviewed changes
@strobelt strobelt force-pushed the add-csharp-tips-to-jump-and-squash-3d-tutorial branch from d8823ec to 88a6d2f Compare October 15, 2023 16:29
@strobelt
Copy link
Contributor Author

strobelt commented Oct 18, 2023

Can this be merged? Or is there something else I should do?

@mhilbrunner mhilbrunner merged commit 4f5b70c into godotengine:master Oct 21, 2023
@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 21, 2023

Indeed it can be :) Thanks and congrats on your first merged contribution to Godot's documentation! 🎉

@strobelt strobelt deleted the add-csharp-tips-to-jump-and-squash-3d-tutorial branch October 21, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@raulsntos raulsntos raulsntos approved these changes

Assignees

No one assigned

Labels

area:getting started Issues and PRs related to the Getting Started section of the documentation enhancement topic:dotnet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@strobelt @AThousandShips @mhilbrunner @raulsntos @Piralein