Close #7690 (add info for shader hints and default values) #8117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
skyace65
approved these changes
Oct 1, 2023
Contributor
skyace65
left a comment
skyace65
left a comment
There was a problem hiding this comment.
Commits need to be squashed, but other than that this looks good.
Contributor
Author
|
Do I need to squash the commits, or does someone else do it? |
Contributor
|
We prefer that contributors do it themselves, however in the docs repository maintainers can do a squash and merge (we can't do this in the engine repository). It's not a big deal since it's your first PR here but just keep it in mind for the future. If you don't know how to keep everything to one commit we have a guide here. |
mhilbrunner
approved these changes
Oct 2, 2023
Member
|
Squashed and merged. Thanks for contributing :) |
Piralein
added
enhancement
area:manual
mhilbrunner
pushed a commit
that referenced
this pull request
Oct 8, 2023
Member
|
Cherry-picked to 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7690
This PR clarifies the syntax for adding both a default value and a hint for shader uniforms.