Clarify where sound files are #8119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
enhancement
area:getting started
mhilbrunner
approved these changes
Oct 2, 2023
Member
|
Should this not be |
skyace65
force-pushed
the
SoundClarification
branch
from
f6aa38f to
8987f07
Compare
Contributor
Author
|
Fixed, not sure what's going on with CI now though |
mhilbrunner
approved these changes
Oct 21, 2023
Member
|
I think it was just a temporary hiccup, I've re-run CI and it succeeded now. Thanks, merged :) |
mhilbrunner
added a commit
that referenced
this pull request
Nov 11, 2023
Clarify where sound files are
Member
|
Cherry-picked to 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8040. There isn't a folder named "assets" the sound clips are in one named "art."