fix #8076, update image and remove note in GDScript warning system docs #8136
Conversation
Hex-4
force-pushed
the
fix-scripting-advanced-settings
branch
from
abcb492 to
711fa18
Compare
|
Could someone please review this? |
|
Hi! It would be really great if someone could review this before the 31st. @skyace65 I don't know if it's okay to ping people here, but it would be nice if you could spare a minute and review this. |
|
What's the rush? We're currently prioritising releasing 4.2 so reviews might be slow, and unfortunately some times documentation PRs are slow to get reviews |
AThousandShips
added
the
area:manual
skyace65
left a comment
skyace65
left a comment
There was a problem hiding this comment.
Removing the note completely without any mention of needing to search for the gdscript section is just going to confuse more people. The existing note should just be updated with another sentence saying "you can also search for the section if advanced settings is off" or something like that.
Hex-4
force-pushed
the
fix-scripting-advanced-settings
branch
2 times, most recently
from
f76e04e to
c010b3a
Compare
|
Thanks for the review! I just pushed a change that hopefully fixes it - should I undo the image change? |
|
Yes, revert to the original image and this should be good to go. |
Hex-4
force-pushed
the
fix-scripting-advanced-settings
branch
from
c010b3a to
eabd668
Compare
|
Thanks! |
|
Great! Sorry for bugging you a little before hehe |
3 participants
closes #8076
This updates the GDScript warning system docs with a new image that doesn't highlight the "advanced" switch and removes the note about having to turn on the "advanced" switch.