close #8074, update mouse and input coordinates page #8149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
reviewed
Oct 5, 2023
Hex-4
force-pushed
the
fix-mouse-and-input-coords-page
branch
from
51a97a4 to
a5811a2
Compare
mhilbrunner
added
bug
area:manual
mhilbrunner
approved these changes
Oct 6, 2023
Member
|
Tiny PR but fixes people running into outdated, non-working code. Great! :) Merged. Thanks Sauermann for the review, and thanks Hex-4 for oncorporating it so quickly and squashing. Nice! |
Sauermann
reviewed
Oct 6, 2023
|
|
||
| # Print the size of the viewport. | ||
| print("Viewport Resolution is: ", get_viewport_rect().size) | ||
| print("Viewport Resolution is: ", get_viewport().get_visible_rect()) |
Contributor
There was a problem hiding this comment.
Unfortunately it looks like I missed size in my suggestion.
It should rather be get_viewport().get_visible_rect().size.
raulsntos
reviewed
Oct 6, 2023
|
|
||
| // Print the size of the viewport. | ||
| GD.Print("Viewport Resolution is: ", GetViewportRect().Size); | ||
| GD.Print("Viewport Resolution is: ", GetViewportRect().GetVisibleRect()); |
Member
There was a problem hiding this comment.
The C# example doesn't match the GDScript example.
Suggested change
| GD.Print("Viewport Resolution is: ", GetViewportRect().GetVisibleRect()); | |
| GD.Print("Viewport Resolution is: ", GetViewport().GetVisibleRect()); |
Contributor
Author
|
Looks like there are a few changes I should make - do I need to make a new PR or can I just amend another commit to this one? |
Contributor
|
You can amend PRs only before they are merged. So creating a new PR is the only viable option. |
Member
|
Cherry-picked to 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8074
Tiny PR that updates the syntax on the mouse and input coordinates page.