Skip to content

Conversation

@dalexeev
Copy link
Member

@dalexeev dalexeev commented Oct 5, 2023

1. Fix nested lists:


2. Fix constant and variable patterns, they are actually literal and expression patterns.

3. Use level 5 headers for match subsections, it looks better and creates anchors. I wanted to add level 6 headers for patterns, but they are almost the same as regular text, which in my opinion looks worse.

4. Fix the funny sentence about 6 types of patterns before a list of 7 items (due to multiple patterns).

5. Add null, false and true to literal table.

6. The shorthands $NodePath and %UniqueNode are not literals.

7. Move warning about comparison since it is not related to the basic syntax

@dalexeev dalexeev added bug enhancement topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 5, 2023
@dalexeev dalexeev force-pushed the gds-update-match-patterns-and-literals branch from d3d1eed to 6ad7f78 Compare October 5, 2023 16:18
@mhilbrunner mhilbrunner merged commit 1d11509 into godotengine:master Oct 5, 2023
@mhilbrunner
Copy link
Member

LGTM, thanks :) Merged.

@dalexeev dalexeev deleted the gds-update-match-patterns-and-literals branch October 5, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug enhancement topic:gdscript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants