Fix wrong property name of AnimatedSprite2D
#8235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saif Kandil <74428638+k0T0z@users.noreply.github.com>
AThousandShips
added
area:getting started
Piralein
approved these changes
Oct 13, 2023
skyace65
approved these changes
Oct 15, 2023
mhilbrunner
approved these changes
Oct 15, 2023
Contributor
|
Using GDScript for the text is fine, thanks! And congrats on your first merged PR! |
Contributor
Author
|
@skyace65 Cool 🙌 |
Member
|
Cherry-picked to 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8204
The property name of
AnimatedSprite2Dis different in GDScript/C#/C++, Idk how godot-docs handles this so feel free to request any changes, please.