fix: vertex coordinates are in local space #8258
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piralein
added
bug
area:manual
clayjohn
reviewed
Oct 19, 2023
| | | **TEXTURE_PIXEL_SIZE** = :code:`vec2(1/64, 1/32)` | | ||
| +--------------------------------+----------------------------------------------------+ | ||
| | inout vec2 **VERTEX** | Vertex, in image space. | | ||
| | inout vec2 **VERTEX** | Vertex, in canvas space. | |
Member
There was a problem hiding this comment.
This should say "local" space. Canvas space is relative to the screen. While the coordinates of the VERTEX are relative to the Node2D and use a pixel scale. The rest of this doc refers to that space as "local" space
Contributor
Author
There was a problem hiding this comment.
Thank you, I will update this.
AThousandShips
changed the title
Member
|
Please squash your commits into one, see here |
Contributor
Author
|
Squashed. Thanks for bearing with me! |
AThousandShips
approved these changes
Oct 19, 2023
clayjohn
approved these changes
Oct 19, 2023
mhilbrunner
approved these changes
Oct 21, 2023
Member
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't for the life of me figure out what was meant with "image space", so I did some experimentation and figured out that the vertex coordinates are actually in "canvas space".