Skip to content

Conversation

@mariomadproductions
Copy link
Contributor

Importing Audio Samples incorrectly said that loop points are in seconds. I've corrected that to say samples (which is the case as of 4.1.2)

Importing Audio Samples incorrectly said that loop points are in seconds. I've corrected that to say samples (which is the case as of 4.1.2)
@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:proofreading Issues and PRs related to proofreading the documentation labels Oct 21, 2023
@AThousandShips AThousandShips requested review from a team October 21, 2023 08:39
Copy link

@ellenhp ellenhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right for WAV files, but for oggs and mp3s the loop points are in seconds, which might be where this came from. Still, oggs and mp3s don't have a loop end import option or selectable loop modes so this is more accurate in context than what was there before.

@mariomadproductions
Copy link
Contributor Author

This is right for WAV files, but for oggs and mp3s the loop points are in seconds, which might be where this came from. Still, oggs and mp3s don't have a loop end import option or selectable loop modes so this is more accurate in context than what was there before.

Ah I see. Thanks.

@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 21, 2023

Merged. Thanks and congrats on your first merged contribution to Godot's docs, and thanks Ellen for the review :)

Note for future PRs: its best practice to create a branch for each PR, instead of submitting them from your main branch.

@mariomadproductions
Copy link
Contributor Author

Merged. Thanks and congrats on your first merged contribution to Godot's docs, and thanks Ellen for the review :)

Note for future PRs: its best practice to create a branch for each PR, instead of submitting them from your main branch.

Thanks, and I'll keep that in mind.

mhilbrunner added a commit that referenced this pull request Nov 11, 2023
Importing Audio Samples: loop points are in samples, not seconds
@mhilbrunner
Copy link
Member

Cherry-picked to 4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.0 content:proofreading Issues and PRs related to proofreading the documentation topic:import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants