More clarity and explanation for audio effects #8304
Conversation
There was a problem hiding this comment.
Many of the lines you've added are too wide, note how the existing lines are broken up and make sure your lines are not too wide
There was a problem hiding this comment.
I just made a commit that does this. I don't know if the lines are perfect, but they seem consistent with the existing break threshold.
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Broke lines down further
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
There was a problem hiding this comment.
Other than one minor issue everything looks good spelling and grammar wise. I can't comment on the technical accuracy of this info though. Also please keep everything in this PR in 1 commit. If you don't know how to do that we have a guide here.
skyace65
added
enhancement
area:manual
Co-authored-by: Matthew <matthewehr@hotmail.com>
|
Looks good to me; at least to the best of my audio knowledge. I've gone ahead and squashed and merged this PR. Thanks for contributing, and congrats on your first merged PR! |
* Update tutorials/audio/audio_effects.rst --------- Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com> Co-authored-by: Matthew <matthewehr@hotmail.com>
|
Cherry-picked to 4.1. |
4 participants
No description provided.