-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix incorrect C# example using _GetConfigurationWarnings
#8375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mhilbrunner
merged 1 commit into
godotengine:master
from
kleonc:get_configuration_warnings_csharp_example
Nov 2, 2023
Merged
Fix incorrect C# example using _GetConfigurationWarnings
#8375
mhilbrunner
merged 1 commit into
godotengine:master
from
kleonc:get_configuration_warnings_csharp_example
Nov 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3aaaaaa to
3ab9cf7
Compare
raulsntos
reviewed
Nov 1, 2023
Member
raulsntos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to the .NET documentation!
3ab9cf7 to
00a296a
Compare
raulsntos
approved these changes
Nov 1, 2023
Member
raulsntos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
mhilbrunner
approved these changes
Nov 2, 2023
Member
|
Thank you :) Merged. |
mhilbrunner
added a commit
to mhilbrunner/godot-docs
that referenced
this pull request
Nov 11, 2023
…nings_csharp_example Fix incorrect C# example using `_GetConfigurationWarnings`
Member
|
Cherry-picked to 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:manual
Issues and PRs related to the Manual/Tutorials section of the documentation
bug
cherrypick:4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7640 only the method name was changed in that example but not the return type.