Skip to content

Conversation

@kleonc
Copy link
Member

@kleonc kleonc commented Nov 1, 2023

In #7640 only the method name was changed in that example but not the return type.

@kleonc kleonc added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.0 cherrypick:4.1 labels Nov 1, 2023
@kleonc kleonc added this to the 4.2 milestone Nov 1, 2023
@kleonc kleonc requested a review from raulsntos November 1, 2023 20:57
@kleonc kleonc force-pushed the get_configuration_warnings_csharp_example branch from 3aaaaaa to 3ab9cf7 Compare November 1, 2023 20:58
@skyace65 skyace65 removed this from the 4.2 milestone Nov 1, 2023
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to the .NET documentation!

@kleonc kleonc force-pushed the get_configuration_warnings_csharp_example branch from 3ab9cf7 to 00a296a Compare November 1, 2023 23:53
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mhilbrunner mhilbrunner merged commit 26516c1 into godotengine:master Nov 2, 2023
@mhilbrunner
Copy link
Member

Thank you :) Merged.

@kleonc kleonc deleted the get_configuration_warnings_csharp_example branch November 2, 2023 10:29
mhilbrunner added a commit to mhilbrunner/godot-docs that referenced this pull request Nov 11, 2023
…nings_csharp_example

Fix incorrect C# example using `_GetConfigurationWarnings`
@mhilbrunner
Copy link
Member

Cherry-picked to 4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants