Update register_types in binding_to_external_libraries.rst #8407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributing/development/core_and_modules/binding_to_external_libraries.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/binding_to_external_libraries.rst
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Related to these comment What should I do ? |
Member
|
Please restore the spaces, it should be spaces and not tabs |
Member
Leave it for a separate decision, let's keep this focused |
AThousandShips
approved these changes
Nov 7, 2023
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
LGTM
Can you please squash your commits into one, see here
AThousandShips
added
area:engine details
…_libraries.rst Based in godotengine/godot#84456 Change register_tts_types() to initialize_tts_module() Change unregister_tts_types() to uninitialize_tts_module() Add parameter ModuleInitializationLevel p_level to uninitialize_tts_module and initialize_tts_module
mhilbrunner
approved these changes
Nov 9, 2023
Member
|
Merged. Thanks and congrats on your first merged contribution! PR welcome to update the writing custom unit tests page too :) |
mhilbrunner
added a commit
to mhilbrunner/godot-docs
that referenced
this pull request
Nov 11, 2023
Update register_types in binding_to_external_libraries.rst
Member
|
Cherry-picked to 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based in godotengine/godot#84456
Change register_tts_types() for initialize_tts_module()
Change unregister_tts_types() for uninitialize_tts_module()