Skip to content

Conversation

@tetrapod00
Copy link
Contributor

Fix for #8439.
If accepted, would supersede #8438.

@skyace65
Copy link
Contributor

Just asking since you made a new PR instead of editing the old one, are you using the github web editor?

@skyace65 skyace65 added enhancement topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 labels Nov 10, 2023
@tetrapod00
Copy link
Contributor Author

tetrapod00 commented Nov 10, 2023

Yes, I'm using the web editor. My contributions so far have been minor fixes, and the web editor seems good enough to make those changes.

In this case I left two PRs because the casing change was uncontroversial, but the int -> uint change may have required discussion or further work.

Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you for contributing to the .NET documentation!

@mhilbrunner mhilbrunner merged commit 9e6534f into godotengine:master Nov 10, 2023
@mhilbrunner
Copy link
Member

Thanks! Merged.

@tetrapod00 tetrapod00 deleted the patch-2 branch November 10, 2023 22:33
mhilbrunner added a commit to mhilbrunner/godot-docs that referenced this pull request Nov 11, 2023
c_sharp_exports.rst: use uint for layers; update casing to C# convention
@mhilbrunner
Copy link
Member

Cherry-picked to 4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants