Skip to content

Conversation

@paddy-exe
Copy link
Contributor

The current Your first 2D shader section is outdated in the Using the TEXTURE built-in section.
Contrary to 3.x the Sprite2D texture won't be overwritten completely when writing to COLOR. Due to 4.x using a separate render pass the texture will still be rendered before any changes are applied. To illustrate:

3.x: The texture is being ignored and a white rectangle appears instead

image

4.x: The texture is only being tinted (the white rectangle only appears in the preview)

image

The guide's wording has to be adjusted accordingly.

@paddy-exe paddy-exe added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:proofreading Issues and PRs related to proofreading the documentation cherrypick:4.0 cherrypick:4.1 cherrypick:4.2 labels Dec 7, 2023
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@paddy-exe paddy-exe force-pushed the update-first-2d-shader-docs branch from 1eca04e to 03ddb93 Compare December 7, 2023 19:46
@paddy-exe
Copy link
Contributor Author

paddy-exe commented Dec 7, 2023

@AThousandShips Thanks for the feedback! Should be good to go now

@skyace65 skyace65 merged commit d7d19fd into godotengine:master Dec 8, 2023
@skyace65
Copy link
Contributor

skyace65 commented Dec 8, 2023

Thanks!

@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.0 cherrypick:4.1 content:proofreading Issues and PRs related to proofreading the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants