-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update navigation mesh baking doc #8591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
535bfe0 to
14cda27
Compare
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
14cda27 to
674f471
Compare
timothyqiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some markers are used incorrectly.
5aa4ac9 to
cf46d62
Compare
AThousandShips
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think some of the sentences need to be broken up with commas or periods, to lessen the mental workload of reading long sentences, especially before connecting words such as "and" and "or"
cf46d62 to
8f0f083
Compare
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have a specific line length limit. But the general rule of thumb is if it is so long it shows up on two lines in github it should be broken up.
Also for the suggested changes on "-" lines make sure the first letter of the second line lines up with the first letter on the first line. I think my suggested changes do but it's hard to tell.
8f0f083 to
9275322
Compare
|
@AThousandShips any other changes that should be made? |
timothyqiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a proofreading. I think it's worth adding some punctuation marks.
Also found a typo. (agent_max_climp -> agent_max_climb)
AThousandShips
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but agreeing with the punctuation suggestions
9275322 to
7a168a5
Compare
Updates navigation mesh baking doc.
7a168a5 to
c8f7e92
Compare
|
Thanks! Great navigation docs as always. |
|
Cherry-picked to 4.2. |
Updates navigation mesh baking doc.
Adds doc for the new 2D navigation mesh baking in Godot 4.2.
Adds examples for NavigationRegion and NavigationServer baking.
Removes the outdated descriptions for the old navigation mesh baking or deprecated functions.
There is a lot of stuff still missing but that will take another few weeks if not months and I don't want the doc to stay completely outdate with wrong information and examples for that long.