Added section on common unsafe operations and their safe counterparts

[AdriaandeJongh]

In trying to learn typed GDScript and enabling all the advanced warnings, I found that there was no guidance anywhere in the docs on how to actually fix those warnings. This is a first attempt at that.

[adamscott]

Nice PR! I would add though some subtitles for each error, making it easy to understand which part applies to which error.

[AdriaandeJongh]

Nice PR! I would add though some subtitles for each error, making it easy to understand which part applies to which error.

Thanks!

I'm new to Sphinx / reST so I don't know if 'subtitles' hints at special reST markup or whether you're using subtitles figuratively ;) Perhaps you could give an example and I'll elaborate on the errors in the PR.

[AThousandShips]

Subsections, which are done with ~ I think, see above with the type hints

[AdriaandeJongh]

Ah, those kinds of subtitles! Added them.

[AdriaandeJongh]

I just pushed a slightly more elaborate description of the examples, and changed the 'fix' of the second example. The old fix would work to get rid of the warning, but would lead to an error at runtime if the object would not be of the type it was casted into.

[AdriaandeJongh]

Thanks for the review @dalexeev – made all the changes you requested, as well as reordered the two examples, and added UNSAFE_PROPERTY_ACCESS to the UNSAFE_METHOD_ACCESS example (because separating them would lead to nearly identical examples, which I don't think would be better? Please advice.)

[dalexeev]

@AdriaandeJongh Sorry for the delay and thanks for your patience! I found no factual errors, my comments contain only additions and style suggestions. @AThousandShips Could you please check the grammar and wording?

[AdriaandeJongh]

@AdriaandeJongh Sorry for the delay and thanks for your patience! I found no factual errors, my comments contain only additions and style suggestions. @AThousandShips Could you please check the grammar and wording?

No worries about the delay – I presume you're drowned in coding yourself and reviewing PRs and whatnot! I appreciate the thorough review. Latest commit is ready for final grammar / style check by @AThousandShips.

[AThousandShips]

Wording and grammar is good

[dalexeev]

Looks good to me.

[mhilbrunner]

Awesome contribution, thanks for taking the time to add these docs. Also thanks everyone for the reviews! Merged. :)

[mhilbrunner]

Cherry-picked to 4.2.