Skip to content

Update textureQueryLevels to mention it returns 1 when the texture is unassigned #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2023
Merged

Update textureQueryLevels to mention it returns 1 when the texture is unassigned #8669

merged 1 commit into from
Dec 24, 2023

Conversation

@jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian commented Dec 22, 2023

@AThousandShips
Copy link
Member

AThousandShips commented Dec 22, 2023

You should target master not 4.2, changes can then be cherry picked, see here.

If you need more information about the update process please see: here. If wanted I can fix the branch for you.

@jsjtxietian
Copy link
Contributor Author

jsjtxietian commented Dec 22, 2023

If wanted I can fix the branch for you.

Yes please!

You should target master not 4.2

It wasn't intentional, I opend the doc page on 4.2 by mistake and started editting it. Thanks, I will be more careful next time.

@AThousandShips AThousandShips changed the base branch from 4.2 to master December 22, 2023 13:31
@AThousandShips AThousandShips added topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:proofreading Issues and PRs related to proofreading the documentation labels Dec 22, 2023
@skyace65 skyace65 merged commit fbfb81d into godotengine:master Dec 24, 2023
@skyace65
Copy link
Contributor

skyace65 commented Dec 24, 2023

Thanks!

mhilbrunner pushed a commit that referenced this pull request Jan 25, 2024
@skyace65 @mhilbrunner
Merge pull request #8669 from jsjtxietian/patch-1
fb31598 
Update textureQueryLevels to mention it returns 1 when the texture is unassigned
@mhilbrunner
Copy link
Member

mhilbrunner commented Jan 25, 2024

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skyace65 skyace65 skyace65 approved these changes

Assignees

No one assigned

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:proofreading Issues and PRs related to proofreading the documentation topic:rendering

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

textureQueryLevels() returns 1 instead of 0 when the texture is unassigned

4 participants

@jsjtxietian @AThousandShips @skyace65 @mhilbrunner