Skip to content

Fixed typo in pr_workflow.rst #8671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2023
Merged

Fixed typo in pr_workflow.rst #8671

merged 2 commits into from
Dec 27, 2023

Conversation

@ramadm
Copy link
Contributor

@ramadm ramadm commented Dec 22, 2023

No description provided.

skyace65
skyace65 requested changes Dec 24, 2023
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd get rid of the "of" in that sentence to make it sound better.

@skyace65 skyace65 added bug area:engine details Issues and PRs related to the Engine Details section of the documentation cherrypick:4.2 labels Dec 24, 2023
@ramadm @skyace65
Update wording in contributing/workflow/pr_workflow.rst
9091292 
Co-authored-by: Matthew <matthewehr@hotmail.com>
@ramadm
Copy link
Contributor Author

ramadm commented Dec 26, 2023

Hi, I committed your change. I see that the docs suggested to keep changes to a single commit when possible, but I'm not sure if it's possible to do that via GitHub's online editor. If you want me to delete and re-submit the PR as a single commit let me know.

@AThousandShips
Copy link
Member

AThousandShips commented Dec 26, 2023

It's okay in this case, but in the future please use the computer setup, just editing from the web interface is very limited 🙂

@skyace65 skyace65 merged commit ae7aa1d into godotengine:master Dec 27, 2023
@skyace65
Copy link
Contributor

skyace65 commented Dec 27, 2023

I've done a squash and merge for this PR so it's only 1 commit, but in the future I'd highly recommend getting setup with a proper editor on your computer for using Git. If you don't know anything about Git we have a guide in the Godot docs here.

Also congrats on your first merged PR!

@ramadm ramadm deleted the patch-1 branch December 28, 2023 07:57
mhilbrunner pushed a commit that referenced this pull request Jan 25, 2024
@ramadm @mhilbrunner
Fixed typo in pr_workflow.rst (#8671)
5a6f6eb 
* Fixed typo in pr_workflow.rst
@mhilbrunner
Copy link
Member

mhilbrunner commented Jan 25, 2024

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skyace65 skyace65 skyace65 approved these changes

Assignees

No one assigned

Labels

area:engine details Issues and PRs related to the Engine Details section of the documentation bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ramadm @AThousandShips @skyace65 @mhilbrunner