Skip to content

Conversation

@GreentheNinja
Copy link
Contributor

No description provided.

@GreentheNinja GreentheNinja changed the title [Minor] Fix typo "Rougness" (should be "Roughness") [Minor] Fix typo in importing_images.rst ("Rougness" should be "Roughness") Dec 25, 2023
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underline must match the heading

When fixing this please do so with git commit --amend if you are using the command prompt, or squash your commits into one


Rougness > Src Normal
Roughness > Src Normal
^^^^^^^^^^^^^^^^^^^^^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
^^^^^^^^^^^^^^^^^^^^^
^^^^^^^^^^^^^^^^^^^^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed, I hope I did that right?

@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:proofreading Issues and PRs related to proofreading the documentation topic:import labels Dec 26, 2023
@skyace65 skyace65 merged commit 29294ee into godotengine:master Dec 28, 2023
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

mhilbrunner pushed a commit that referenced this pull request Jan 25, 2024
[Minor] Fix typo in `importing_images.rst` ("Rougness" should be "Roughness")
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

@GreentheNinja GreentheNinja deleted the patch-1 branch June 21, 2024 09:18
@GreentheNinja GreentheNinja restored the patch-1 branch June 21, 2024 09:20
@GreentheNinja GreentheNinja deleted the patch-1 branch June 21, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 content:proofreading Issues and PRs related to proofreading the documentation topic:import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants