Fixed unordered list markup in "Converting GLSL to Godot shaders" #8694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Your branch is started from the wrong point, this needs to be fixed as it contains incorrect commits If you need more information about the update process please see: here. If wanted I can fix the branch for you. |
AThousandShips
added
the
needs work
The unordered list markup was missing a blank line at the beginning, so it displayed all the list item on a single line of text instead of in a proper bulleted list.
AThousandShips
force-pushed
the
patch-1
branch
from
666913f to
83cad83
Compare
AThousandShips
added
topic:rendering
area:manual
Member
|
Fixed it for you 🙂 |
mhilbrunner
approved these changes
Jan 15, 2024
Member
|
Merged. Thanks and congrats on your first merged contribution! |
Contributor
Author
|
Thanks for the help! I'll do it better next time.
…________________________________
From: A Thousand Ships ***@***.***>
Sent: Tuesday, January 2, 2024 2:36 AM
To: godotengine/godot-docs ***@***.***>
Cc: seadylan ***@***.***>; Author ***@***.***>
Subject: Re: [godotengine/godot-docs] Fixed unordered list markup in "Converting GLSL to Godot shaders" (PR #8694)
Fixed it for you 🙂
—
Reply to this email directly, view it on GitHub<#8694 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACFLB5Z34HCU7B3Q6HKJQMTYMPPLXAVCNFSM6AAAAABBICIOE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTHA2TMOJQGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
mhilbrunner
added a commit
that referenced
this pull request
Jan 25, 2024
Fixed unordered list markup in "Converting GLSL to Godot shaders"
Member
|
Cherry-picked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unordered list markup was missing a blank line at the beginning, so it displayed all the list item on a single line of text instead of in a proper bulleted list.