Replace yield with await in gd script for http client tutorial #8707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wait instead of synchronous OS delay also on non-web platforms
mhilbrunner
approved these changes
Jan 2, 2024
mhilbrunner
added
area:manual
skyace65
approved these changes
Jan 6, 2024
Contributor
|
Thanks! And congrats on your first merged PR! |
mhilbrunner
pushed a commit
that referenced
this pull request
Jan 25, 2024
Replace yield with await in gd script for http client tutorial
Member
|
Cherry-picked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the HTTPClient node used the old yield syntax for waiting an idle frame. In Godot 4, this should be replaced with the new await syntax. The blocking OS.delay_msec on the non-web platforms should also be replaced with an asynchronous await statement.