-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Improve navigation mesh code examples #8714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improves navigation mesh code examples.
216775f to
df8b911
Compare
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me!
|
The |
What parts are you referring to? Tilemap issues are common and TileMap does not really inform its users in that regard. The "Where is this all documented?" question is raised a lot by users when I explain TileMap specific quirks to them. I was think of adding even a section just for the TileMap because it has so many specific problems that users commonly fall into. |
| # Some mega-nodes like GridMap are often not ready on the first frame. | ||
| # Also the parsing needs to happen on the main-thread. | ||
| # So do a deferred call to avoid common parsing issues. | ||
| parse_source_geometry.call_deferred() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, specifically. Again, better to document this than not, but maybe something we should file somewhere to see if we can improve UX here.
|
Thanks! |
Improve navigation mesh code examples
|
Cherry-picked to 4.2. |
Improves navigation mesh code examples.
Users had trouble adapting the example code snippets to their projects, struggling with how to make things reusable or with other specifics.
The improved examples are now longer but show nearly the entire flow from start to finish how to create and update navigation meshes in scripts and mention some common problems with e.g. TileMap shenanigans or SceneTree processing.