Update scripting_player_input.rst #8722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commenting out code from the previous exercise that causes the icon to float up, making it difficult for users to see the example of directional input.
Removing unnecessary spaces in C# comments Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
skyace65
added
enhancement
area:getting started
skyace65
requested changes
Jan 23, 2024
Contributor
skyace65
left a comment
skyace65
left a comment
There was a problem hiding this comment.
You need to tell people to un-comment the Position line in the next section, otherwise that code doesn't work.
Updating phrasing per suggestion Co-authored-by: Matthew <matthewehr@hotmail.com>
Informing user to uncomment the commented code.
kylestarr
commented
Jan 26, 2024
|
|
||
| To only move when pressing a key, we need to modify the code that calculates the | ||
| velocity. Replace the line starting with ``var velocity`` with the code below. | ||
| velocity. Uncomment the code and replace the line starting with ``var velocity`` with the code below. |
Contributor
Author
There was a problem hiding this comment.
@skyace65 I've made a simple update that accounts for both comments.
skyace65
approved these changes
Jan 27, 2024
Contributor
|
Thanks! |
mhilbrunner
pushed a commit
that referenced
this pull request
Jul 24, 2024
Update scripting_player_input.rst (cherry picked from commit a621959)
Member
|
Cherry-picked to 4.2 in #9648. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commenting out code from the previous exercise that causes the icon to float up, making it difficult for users to see the example of directional input.