Update thread_safe_apis.rst to mention don't call certain rendering functions on other threads #8749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions on other threads
mhilbrunner
approved these changes
Jan 13, 2024
mhilbrunner
added
enhancement
area:manual
AThousandShips
approved these changes
Jan 24, 2024
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
Looks good otherwise, just think this makes the sentence flow better
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Member
|
Merged. Thanks for contributing! 🎉 |
Contributor
|
We may want to keep an eye out for this doc change because the work I'm doing for transfer queues means this will no longer hold true, as texture and buffer creation will be thread-safe and not imply synchronization (if it makes it in for 4.3 I guess). |
mhilbrunner
added a commit
that referenced
this pull request
Jan 25, 2024
…unctions on other threads (#8749) * Update thread_safe_apis.rst to mention don't call certain rendering functions on other threads --------- Co-authored-by: Max Hilbrunner <mhilbrunner@users.noreply.github.com> Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Member
|
Cherry-picked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For godotengine/godot#86796
But I bet my writing is not good, feel free to correct me if any.