Skip to content

Conversation

@AnOpenSauceDev
Copy link
Contributor

Fixes multiple cases where "Amount" was incorrectly spelled as "Ammount", also fixes a typo where "Ratio" was spelled as "Radio".

@Mickeon
Copy link
Member

Mickeon commented Jan 27, 2024

Very nice, could you rebase those those commits?

@Mickeon Mickeon added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement cherrypick:4.2 labels Jan 27, 2024
Changed "Ammount" to "Amount", and "Radio" to "Ratio".
@Mickeon
Copy link
Member

Mickeon commented Jan 27, 2024

You merged 2 out of 3, it would be nice to have just one commit with both.

Copy link
Member

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That aside, this is nice.

@skyace65 skyace65 merged commit 67b1795 into godotengine:master Jan 27, 2024
@skyace65
Copy link
Contributor

Thanks! Since this is your first PR I've done a squash and merge but in the future we need you to keep everything to 1 commit. If you don't know how to do that when editing a PR there's another section on the page Mickeon linked to that goes over that (this section). Also congrats on your first merged PR!

mhilbrunner pushed a commit that referenced this pull request Jul 24, 2024
* Fix typo: Ammount -> Amount

* Fix typos in `properties.rst`

Changed "Ammount" to "Amount", and "Radio" to "Ratio".

(cherry picked from commit 67b1795)
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9648.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants