Skip to content

Conversation

@scotmcp
Copy link
Contributor

@scotmcp scotmcp commented Jan 31, 2024

line 2016 references Class, should reference Resource

@scotmcp
Copy link
Contributor Author

scotmcp commented Jan 31, 2024

I meant to say, "line 2016 references GDScript, should reference Resource"

@AThousandShips
Copy link
Member

You should target master not 4.2, changes can then be cherry picked, see here.

If you need more information about the update process please see: here. If wanted I can fix the branch for you.

@AThousandShips AThousandShips changed the base branch from 4.2 to master January 31, 2024 11:08
@AThousandShips AThousandShips added the needs work Needs additional work by the original author, someone else or in another repo label Jan 31, 2024
@AThousandShips
Copy link
Member

Also this is false, try this:

print(preload("res://some_script.gd"))

And you will see it prints <GDScript#...>, not <Resource#...>

@scotmcp
Copy link
Contributor Author

scotmcp commented Jan 31, 2024

I think you are miss understanding....if you look at the documentation is says "treated as a resource" with a link that says resource, but the LINK itself points to GDScript. That's what I am correcting....the link, not the English statement.

image

@AThousandShips
Copy link
Member

Well then that wasn't clear from your description 🙂, the link text should be changed instead as it's more correct to point to the actual type that will be returned

@AThousandShips
Copy link
Member

Should probably say "GDScripts" as the previous said "resources", in either case the current wording isn't correct grammar

@AThousandShips
Copy link
Member

I rebased your branch for you

@AThousandShips AThousandShips added topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation and removed needs work Needs additional work by the original author, someone else or in another repo labels Jan 31, 2024
@AThousandShips AThousandShips requested a review from a team January 31, 2024 18:00
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
@skyace65 skyace65 merged commit 6a6f786 into godotengine:master Feb 2, 2024
@skyace65
Copy link
Contributor

skyace65 commented Feb 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:gdscript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants