Skip to content

Conversation

@skyace65
Copy link
Contributor

@skyace65 skyace65 commented Feb 4, 2024

Removes duplicate info which made the page confusing to read. Closes #8312.

@skyace65 skyace65 added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.2 labels Feb 4, 2024
@skyace65
Copy link
Contributor Author

skyace65 commented Feb 6, 2024

Yeah I probably shouldn't have made this PR while tired. Updated it. Switched which code example is deleted and removed the reference to get_node().

@skyace65 skyace65 requested a review from Piralein February 6, 2024 02:52
Copy link
Member

@Piralein Piralein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C# sections still mentions the GetNode() with typecast. Maybe the example should just be moved below the:

Note that autoload objects (scripts and/or scenes) are accessed just like any other node in the scene tree

as it contains both the GDscript and C# example. Either way solves the linked issue.

@mhilbrunner mhilbrunner merged commit 5c926b5 into godotengine:master Feb 8, 2024
@mhilbrunner
Copy link
Member

Thanks!

@skyace65 skyace65 deleted the Autoload branch March 5, 2024 01:40
mhilbrunner added a commit that referenced this pull request May 7, 2024
Remove duplicate information in autoload page

(cherry picked from commit 5c926b5)
@mhilbrunner
Copy link
Member

Cherrypicked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing wording on Autoload / Singleton article

3 participants