-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Clarify C# GlobalClass exported node behavior #8923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
paulloz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It is way more understandable. It took me a couple of times re-reading the current page to understand what it meant.
Also, the new screenshot is a bit tiny, which is aesthetically unpleasing for me, but probably not a deal-breaker.
On my screen (100% scaling, non-4k, FWIW) the font size seems the same as the existing images, which I was thinking is what matters. Just to make sure there's no rendering difference, here's what old (left) and new (right) look like to me: And the unchanged screenshots: I would agree the editor font used on this page overall is too small though. Is there a contrib guide page that has something like "recommended screenshot theme settings"? I think having that on https://docs.godotengine.org/en/stable/contributing/documentation/docs_image_guidelines.html would be nice. (Maybe even with a note that it's ok to have mismatched sizes if a page's existing shots don't fit the guidelines.) |
paulloz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK for me. Thanks ❤️
raulsntos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too. And thanks for the new icon 🙏.
|
Thanks! |


When following this link on the C# exports page:
This sentence in the intro paragraph seems relatively easy to misinterpret:
Someone took this to mean that exported custom node properties must be global classes (or derived from a global class). I hadn't read the intro to this doc yet when they brought it up, and reading it for the first time with this interpretation in mind (even though I was fairly sure it wasn't right), I also interpreted it that way.
After digging into it, I understand what it's trying to say, and I think it's worth clarifying. I added a bit more about how the restriction and filtering is helpful.
I retook the
img/globalclasses_addnode.webpscreenshot to get rid of some dead space that was making it harder to scroll through the page. (Seemed more noticeable once I added more content.)