-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Node type customization warning updated to explain suffix options #8950 #8951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node type customization warning updated to explain suffix options #8950 #8951
Conversation
12ecce2 to
badf7f2
Compare
|
Thanks for testing. It's my mistake not testing "$" symbol. Case conversion for it happens differently. Other two symbols are lower cased and then checked, but "$" is used with So, I assume nodes are being imported as a child of rigidbody node and I will test them again. Should I just write down all three symbols are case-insensitive after that? |
|
Yes, if you're seeing that everything is case insensitive for you as well update the PR. When you do please keep your PR to 1 commit, if you don't know how to do that we have a guide here. |
badf7f2 to
d48821c
Compare
|
Thanks, updated now. |
tutorials/assets_pipeline/importing_3d_scenes/node_type_customization.rst
Outdated
Show resolved
Hide resolved
d48821c to
a4a1763
Compare
tutorials/assets_pipeline/importing_3d_scenes/node_type_customization.rst
Outdated
Show resolved
Hide resolved
a4a1763 to
e41af09
Compare
|
Thanks! Congrats on your first merged PR! Also just so you know github has a feature where if you write "closes #issue number" in your PR description it will automatically close that issue when the PR is merged. |
|
Good to know, thank you! |

Suffix options for resource importing in 3d scenes can actually be used with multiple symbols with different case sensitivity. Pointed in this issue: #8950