-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update docs page introduction_to_3d to accurately explain Transform3D #9174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You probably started your PR branch from either an outdated version of the repo's |
|
I followed your instructions and believe that I fixed the issue, thank you! Please let me know if there is anything further I need to do |
|
You haven't fixed it fully, there's still incorrect commits in it, please do |
As pointed out in Issue godotengine#8904, a Transform3D is a 3x4 transformation matrix, not a 4x3. While that issue does point out other areas of concern on this specific page, this update is simply to fix that error. The change can be found on line 35.
|
Ok ok I believe it should finally be good now, unless 3b877c8 is getting in the way of anything. Thank you! |
|
Still got the wrong versions, you need to do the |
|
how about now? |
|
Thank you, it indeed looks perfect now :) Congrats on your first merged contribution to Godot's docs! 🎉 |
|
thank you for your assistance :) |
|
Cherry-picked to 4.2 in #9648. |
As mentioned in Issue #8904, a Transform3D is a 3x4 matrix, not a 4x3. This simply updates line 35 in introduction_to_3d.rst to match.
edit: I did not mean to try to merge 99 commits, I only wanted to request merge the one that I was making, and I'm afraid that I messed up.