ERROR: store_buffer: Condition ' !p_src ' is true when doing some operations.

[qarmin]

Godot version:
3.2.beta.custom_build. 157246a
OS/device including version:
Ubuntu 19.10
Issue description:

Using null buffer pointer in fwrite function is Undefinied Behaviour

size_t fwrite(
   const void *buffer,
   size_t size,
   size_t count,
   FILE *stream
);

and this cause this error

ERROR: store_buffer: Condition ' !p_src ' is true.
   At: drivers/unix/file_access_unix.cpp:278.

It can be easily silenced but probably this is not the best solution

Steps to reproduce:

1. Download "FirstPersonStarter" from Template in Project Manager

godot/scene/main/http_request.cpp

Line 358 in 24e1039

file->store_buffer(r.ptr(), chunk.size());

2.
Import GLTF File Katalog bez nazwy.zip

godot/core/io/resource_format_binary.cpp

Line 1538 in dec10dd

f->store_buffer(r.ptr(), len);

[jameswestman]

I'm also seeing this issue when downloading files with the HTTPRequest node. The download still works, though.

[git2013vb]

I have the exactly the same error when I use this plugin: https://github.com/fenix-hub/godot-engine.text-editor
I use 3.2beta4.mono with Debian 10

ERROR: store_buffer: Condition ' !p_src ' is true.
   At: drivers/unix/file_access_unix.cpp:278.
ERROR: store_buffer: Condition ' !p_src ' is true.
   At: drivers/unix/file_access_unix.cpp:278.

[Touitoui]

I have the same error. I don't have any plugin and i don't use HTTPRequest but i do have GLTF files imported from blender. (Created from scratch and exported by me with the latest version of blender).

It always happen in the script editor when i have an "error" in my code (ex: when writting an "if" before putting the ":" at the end).

It freeze the whole program for a few minutes... But if godot was started from a terminal, i can do a ctrl+c in it and godot will unfreeze like nothing happened ! Not exiting the program, just unfreezing it.

I use Godot_v3.2.1-stable_x11.64 on Ubuntu 18.04.4 LTS

[dpensky]

I also have this problem every time I use http_request to download a file on the android exported version of my game.
Using Engine: 3.2.3-stable (official)
Engine running on Ubuntu 16.04
Exported game running on Android 9
The download works correctly, only the debug log is too flooded:

[avnerh1]

This solved the problem in my case:
$HTTPRequest.download_chunk_size = 65535

[Calinou]

This solved the problem in my case:
$HTTPRequest.download_chunk_size = 65535

For reference, this is now the default in 3.3rc: #42896

[avnerh1]

This solved the problem in my case:
$HTTPRequest.download_chunk_size = 65535

For reference, this is now the default in 3.3rc: #42896

In 3.3, this doesn't solve the problem.
And although the file is still downloaded successfully, HTTPRequest.get_body_size() returns -1 instead of the actual file size.

[Calinou]

HTTPRequest.get_body_size() returns -1 instead of the actual file size.

This is expected with some file hosts such as GitHub because they don't report the body size for files that were generated on-the-fly (such as ZIP archives). In this situation, you will get the body size if you try downloading the same file a second time in a short enough interval.

[avnerh1]

HTTPRequest.get_body_size() returns -1 instead of the actual file size.

This is expected with some file hosts such as GitHub because they don't report the body size for files that were generated on-the-fly (such as ZIP archives). In this situation, you will get the body size if you try downloading the same file a second time in a short enough interval.

That's generally true, but in my case these are the same specific files of which get_body_size() returns the actual size when exporting with Godot v3.2.3 but not when exporting with v3.3.

[Calinou]

@avnerh1 Which platform are you testing this with? The HTML5 HTTPClient has been rewritten to use fetch(), so it's possible that there may be regressions. Please create a new issue with a minimal reproduction project attached.

[volzhs]

I got similar error when running on android device via editor. 305c364

[avnerh1]

@avnerh1 Which platform are you testing this with? The HTML5 HTTPClient has been rewritten to use fetch(), so it's possible that there may be regressions. Please create a new issue with a minimal reproduction project attached.

I'm using Win10/Edge.

[tavurth]

I'm having this issue on Mac OS X.

The problem occurs in both debug mode (editor) and exported versions.

const endpoint = "https://query1.finance.yahoo.com/v8/finance/chart/AAPL?symbol=AAPL&period1=1614957299&period2=1620054899&useYfid=true&interval=15m&includePrePost=false"
const headers = [
	"Content-Type: application/json",
	"Accept-Encoding: gzip"
]

var http
http = HTTPRequest.new()
http.download_chunk_size = 65535
http.download_file = "user://test.gz"

self.add_child(http)

var result = http.request(endpoint, headers, true)
assert(result == OK)

result = yield(http, "request_completed")